search

depjs / dep

A little Node.js dependency installer
https://github.com/depjs/dep#readme
MIT License
189 stars 15 forks source link

Support `git submodule update --init --recursive` #41

Closed watilde closed 7 years ago

watilde commented 7 years ago

Summary

git dependency sometimes has .gitmodules. That also should be installed if it's not in .npmignore.

Steps to reproduce behavior

Install this package.json

{
  "devDependencies": {
    "rpc-tests": "github:ethereum/rpc-tests#9727606"
  }
}

Expected behavior

Submodules should be installed

$ ls node_modules/rpc-tests/lib/tests/
ABITests         BlockchainTests  KeyStoreTests    README.md        StateTests       TransactionTests VMTests
BasicTests       GenesisTests     PoWTests         RLPTests         TODO             TrieTests        ansible

Actual behavior

They are not installed

$ ls node_modules/rpc-tests/lib/tests
ls: node_modules/rpc-tests/lib/tests: No such file or directory
watilde commented 7 years ago

In npm: https://github.com/zkat/pacote/blob/latest/lib/util/git.js#L65