search

deplinenoise / tundra

Tundra is a code build system that tries to be accurate and fast for incremental builds
MIT License
438 stars 75 forks source link

Ensure DriverOptions.m_QuickstartGen defaults to false #321

Closed Kalmalyzer closed 5 years ago

Kalmalyzer commented 5 years ago

I noticed that on my machine (windows 10 64-bit), the latest pre-built version of tundra2 would run the quickstart generation even if I did not supply the -Q commandline option. Net result: whenever I tried building an existing project, it would stomp over the existing tundra.lua and then exit :)

Looks like this is down to an uninitialized variable. This change (not compiled, not test-run) ought to resolve that problem. I believe that this change should fix it.

(In the future it might be better to move the initialization to use C++11 style member initializers in the .hpp file - much easier to spot this sort of mistakes then)

Kalmalyzer commented 5 years ago

Wait. I just realized that the two other outstanding PRs fix the exact same problem. Closing.