search

deplorableword / textmate-solarized

TextMate theme for Solarized
http://ethanschoonover.com/solarized
440 stars 98 forks source link

Set background color to correct Solarize hex value. Fixes issue #20 #21

Closed rdlugosz closed 12 years ago

rdlugosz commented 12 years ago

Like the commit says... minor changes to get the hex values set to the standard-issue Solarize spec. Note that I haven't checked for issues with the "light" version of the theme since I haven't used it.

paulmillr commented 12 years ago

too ugly. :-1:

Solarized site says it should look like this

rdlugosz commented 12 years ago

@paulmillr I think you've got something set up wrong; check the screen shot to see how my Textmate looks.

Note that my PR is only to adjust the background & highlight colors to what they should be per the hex values in the Solarized spec. For some reason this theme is not using the correct values for these params; my patch fixes that. Perhaps @deplorableword could provide some info as to why the theme didn't use these settings originally.

screen grab

I do agree that my Textmate looks a little brighter (esp the background) than the Solarized example images. Not sure why this is the case since the hex values match... :/

paulmillr commented 12 years ago

perhaps, that's because I use TM2

rdlugosz commented 12 years ago

Could be; I don't think themes are directly portable to TM2 (yet?). I am using TM2 but I think I manually set up the color scheme as opposed to using a theme file.

deplorableword commented 12 years ago

@thatRD Hey, it's possible there was a human error involved in setting the background colour initially and it's been co close that nobody actually checked. I normally use light, so it's possibly why it's gone unchecked so for so long. I'll merge this in now. Thanks for spotting it :)

What I'd like to have in the future is some kind of validator which reads the theme XML for solarised approved colours and warns if a non-standard colour has been added.

In terms of TM2 when major chunks of new highlighting has been added, I've give them a little nudge and that branch is updated. Once TM2 is out we can figure out the best way to maintain both versions.

rdlugosz commented 12 years ago

cool. thx!

devinus commented 12 years ago

This pull request is wrong. There are screenshots of Solarized all over that show the correct color for dark's background.

Example:

It seems you've set what should be the line number gutter color in VIM to be the entire bg color.