search

deplorableword / textmate-solarized

TextMate theme for Solarized
http://ethanschoonover.com/solarized
440 stars 98 forks source link

TextMate 2 and base text color #25

Open ebsen opened 12 years ago

ebsen commented 12 years ago

It looks like there's something gone awry with the base text color used in this theme under TextMate 2.

Until yesterday, the Solarized theme available as a TextMate 2 bundle was independent of this one. (It didn't support Markdown highlighting, at least.) Yesterday, this changed, but now the base text color renders in some kind of greenish yellow, no matter what the language bundle used. (Try a plain text file to see what I mean.)

Coincidentally, this is the same issue that I found when I tried to convert my copy of this theme into a TextMate 2 version.

It seems as though maybe MacroMates pulled this repo into their theme?

deplorableword commented 12 years ago

Hi,

I need to look into this but, in short I normally poke someone at textmate to update the TM2 theme from this repo, either they hit the trigger without me asking or it's now tracking and updating automatically.

Errors are probably due to the latest merges, normally people get a stable copy of the theme via the main Solarised download or via TM2 auto update.

Sorry for this, it sucks. I'll see what I can do to get it resolved.

On 27 Mar 2012, at 06:44 PM, eriklebsenreply@reply.github.com wrote:

It looks like there's something gone awry with the base text color used in this theme under TextMate 2.

Until yesterday, the Solarized theme available as a TextMate 2 bundle was independent of this one. (It didn't support Markdown highlighting, at least.) Yesterday, this changed, but now the base text color renders in some kind of greenish yellow, no matter what the language bundle used. (Try a plain text file to see what I mean.)

Coincidentally, this is the same issue that I found when I tried to convert my copy of this theme into a TextMate 2 version.

It seems as though maybe MacroMates pulled this repo into their theme?

Reply to this email directly or view it on GitHub: https://github.com/deplorableword/textmate-solarized/issues/25

ebsen commented 12 years ago

Yeah, mine came through automatically. Took me awhile to make sure I hadn't broken something myself before I filed the issue. No worries, thanks.

nsfmc commented 12 years ago

i noticed this too and asked around in irc, but foolishly hadn't thought to try looking here

deplorableword commented 12 years ago

Hi,

I've just pushed a fix to this https://github.com/deplorableword/textmate-solarized/commit/364ec37ea0ed29f4a41bd318f8de4266f8d05b82 to add an addition rule for text.plain to set the default text correctly. Interestingly we had never set this before, so I'm still at a loss to what went wrong here. I don't think any additional contexts get applied to 'plain' text, so I'm going to leave this issue open until I know what went wrong.

ebsen commented 12 years ago

So I downloaded your revised light theme and stuck it in ~/Library/Application Support/Avian/Bundles/, then uninstalled the Solarized theme from the TextMate 2 bundles panel, and restarted TextMate 2 (just to be sure).

Now, with the Plain Text "language" selected, the text appears correct (without double-checking the hex values), but switching the language highlighting to Markdown returns the text to that greenish-yellow color.

I can provide further details if you want/need, but thought I'd jot down what I noticed so far in case its any help.

deplorableword commented 12 years ago

Ah must be another context which needs to be added, can you supply an example gist with another broken colour?

Thanks

On 28 Mar 2012, at 11:03 PM, eriklebsenreply@reply.github.com wrote:

So I downloaded your revised light theme and stuck it in ~/Library/Application Support/Avian/Bundles/, then uninstalled the Solarized theme from the TextMate 2 bundles panel, and restarted TextMate 2 (just to be sure).

Now, with the Plain Text "language" selected, the text appears correct (without double-checking the hex values), but switching the language highlighting to Markdown returns the text to that greenish-yellow color.

I can provide further details if you want/need, but thought I'd jot down what I noticed so far in case its any help.

Reply to this email directly or view it on GitHub: https://github.com/deplorableword/textmate-solarized/issues/25#issuecomment-4792521

ebsen commented 12 years ago

I hope this is what you were looking for. I made a gist containing three files: plain text, Markdown, and JavaScript. The base text color appears correct in the .txt file (base00?); however, in the .js and .mdown copies, the "regular" text still displays in that green/yellow. I haven't noticed a problem with the other colors.

Update: The noob here (me) can't figure out how to link to the gist. It's the only gist I have and it should be public if that helps at all.

nsfmc commented 12 years ago

hey, so i looked at this and just wrapped it in a native tm2 bundle in a separate branch here:

https://github.com/nsfmc/textmate-solarized/tree/tm2

the actual changes to the plists were only cutting extraneous whitespace which magically fixed the problem (i guess tm2 is more sensitive on that front?)

@deplorableword if you'd like i can merge those changes back into the main tmthemes from your repo and pull request it, otherwise, i'll just leave this here if that helps anyone else

ebsen commented 12 years ago

I don't see any difference using the link provided by @nsfmc .

oesmith commented 12 years ago

@nsfmc's branch fixes the problem for me!

cd ~/Library/Application Support/Avian/Bundles/
git clone -b tm2 https://github.com/nsfmc/textmate-solarized.git Solarized.tmbundle
ebsen commented 12 years ago

Thanks, @oesmith. @nsfmc's branch works using your instructions. Apparently just downloading the files and dropping them into the themes directory of my own bundle doesn't do the trick.