search

deplorableword / textmate-solarized

TextMate theme for Solarized
http://ethanschoonover.com/solarized
440 stars 98 forks source link

Adding SublimeLinter Colorization #31

Closed Iristyle closed 11 years ago

Iristyle commented 12 years ago

Using various base colors as outlines, red underline for errors, orange underline for violations, yellow underline for warnings.

These colors are consistent with the official Solarized colors

base03: #002b36 base02: #073642 base01: #586e75 base00: #657b83 base0: #839496 base1: #93a1a1 base2: #eee8d5 base3: #fdf6e3 yellow: #b58900 orange: #cb4b16 red: #dc322f magenta: #d33682 violet: #6c71c4 blue: #268bd2 cyan: #2aa198 green: #859900

deplorableword commented 12 years ago

Could these be added to the light theme as well?

Iristyle commented 12 years ago

Sure --- are you cool with the same red / orange / yellow colorizations on that side of the fence?

(BTW - I'm also going to fix the remaining out-of-spec colors today -- have figured out what colors should be replaced, just have to check on a few test files to be sure)

deplorableword commented 12 years ago

Any chance you could throw up a quick screenshot? I don't have TM setup correctly on this machine. Thanks for figuring out the incorrect colours :)

Iristyle commented 12 years ago

I created a gist demonstrating the differences in colors for underlines, etc:

https://gist.github.com/3360526

This should be pull-ready. I will create a new branch / pull request for standardizing the other colors.

Iristyle commented 11 years ago

Likewise, was hoping that these additions could be accepted.

I was able to get this repo accepted into the feed for Sublime Package Control, so this is the repo now for Sublime.... I'd rather not have to fork / maintain a separate copy.

deplorableword commented 11 years ago

Sorry, I've out of the mix and have switched machines. These look good, I'll merge in.

In terms of this being the repo for Sublime now, that's great. Do you want to fork the readme and add in any relevant details that sublime text users might need to know?