search

deplorableword / textmate-solarized

TextMate theme for Solarized
http://ethanschoonover.com/solarized
440 stars 98 forks source link

Changed all colors to standard Solarized colors. #32

Closed Iristyle closed 11 years ago

Iristyle commented 12 years ago

Here are various screen captures -- the only major concern is the red next to orange in Ruby. Maybe Ruby just needs to switch the red or orange to a different color. https://gist.github.com/3361667

Info for commit

base03 #002B36 - from #000000 base01 #586E75 - from #536871 base00 #657B83 - from #708284|#6a8187 base0 #839496 - from #819090|#899090 base2 #EEE8D5 - from #EAE3CA|#E0EDDD|#EAE3C9 yellow #B58900 - from #A57705|#A57706|#A57800 orange #CB4B16 - from #BB3700|#BD3613|#BD3800|#BF3904 red #DC322F - from #B81D1C|#C60000|#CD1E1D|#D01F1E|#D30102|#D31E1E|#D3201F violet #6C71C4 - from #5A74CF cyan #2AA198 - from #219186|#269186|#469186 green #859900 - from #738A05|#738A13|#748B00

Standard colors from the palette are base03: #002b36 base02: #073642 base01: #586e75 base00: #657b83 base0: #839496 base1: #93a1a1 base2: #eee8d5 base3: #fdf6e3

red: #dc322f magenta: #d33682 violet: #6c71c4 blue: #268bd2 cyan: #2aa198 green: #859900

deplorableword commented 12 years ago

Tad confused, these are screenshots of Sublime on windows?

Iristyle commented 12 years ago

Yup, last I checked RGB hex colors are the same on all platforms ;0

alexroper commented 12 years ago

I think @deplorableword might be confused if doesn't know Sublime Text can use native TextMate themes.

deplorableword commented 12 years ago

I'm aware that Sublime can accept TM themes, just need to test that these don't break anything from TM1+2 users. Still surprised that Sublime doesn't maintain it's own fork tbh

Iristyle commented 12 years ago

Why maintain another repo if they work the same?

I didn't replace anything other than color values, just take a look at the comment above / matching diff -- not sure how that could break anything.

Iristyle commented 11 years ago

I was really hoping that you would accept this pull... any reason you haven't yet?

braver commented 11 years ago

@Iristyle please have a look at this: https://github.com/deplorableword/textmate-solarized/issues/33#issuecomment-9412305. I'm really starting to think we should move to a separate fork for Sublime.

braver commented 11 years ago

@deplorableword I feel a bit like a bunch of Sublime users came over, messed up your repo, and then moved out. Is there anything I can do? I've got a little reference table for flipping a theme from dark to light. It should be pretty easy to work out what the colors should be for Textmate and put that table in the readme here. It may be best to revert some of the recent color changes and then work from that table to correct what's left?

deplorableword commented 11 years ago

Closing because Sublime moved into a separate fork etc etc