search

deplorableword / textmate-solarized

TextMate theme for Solarized
http://ethanschoonover.com/solarized
440 stars 98 forks source link

Background color for dark theme are significantly lighter than Solarized screenshots #33

Open devinus opened 12 years ago

devinus commented 12 years ago

Solarized uses a dark blue color, what you get from this theme is turquoise.

Current background:

Solarized background:

devinus commented 12 years ago

It seems this was broken in PR #21.

braver commented 11 years ago

This is really odd. The Hex value that has been set in PR #21 is correct in that it matches with the spec. In Sublime Text 2 this results in exactly the right color. Digitial Color Meter on my mac reports the background in Sublime Text 2 to be RGB 0 43 54, in your Vim screenshot it's 0 42 53 (which is propably due to compression or something), but your Textmate screenshot is way off at 0 57 71. Whatever it is, your Textmate isn't displaying what it should be displaying. Do you have a transparency setting floating around somewhere or something?

deplorableword commented 11 years ago

I'm not sure what monitor colour profiles do to digital colour meter.

You got some screenshots?

On 13 Oct 2012, at 07:57 AM, braver notifications@github.com wrote:

This is really odd. The Hex value that has been set in PR #21 is correct in that it matches with the spec. In Sublime Text 2 this results in exactly the right color. Digitial Color Meter on my mac reports the background in Sublime Text 2 to be RGB 0 43 54, in your Vim screenshot it's 0 42 53 (which is propably due to compression or something), but your Textmate screenshot is way off at 0 57 71. Whatever it is, your Textmate isn't displaying what it should be displaying. Do you have a transparency setting floating around somewhere or something?

— Reply to this email directly or view it on GitHub.

braver commented 11 years ago

Ok, I checked, and I don't have an explanation... (I need to figure out how to get the screenies inside github some day)

sublime textmate

I think you should be able to grab a screenhots of Textmate and open it with anything that has a color picker (photoshop, paint.net, the gimp etc) and figure out what color the background is yourself.

I think that if Textmate is getting the same input value as Sublime they should both render the same value. Monitor profiles only change the way RGB values are displayed on your monitor (the way they are translated to the hardware), they don't affect the RGB values directly so that's not relevant (I'm using a software color meter here). What I'm seeing here is that I tell Textmate to make the background 0 43 55 but it makes the background 0 57 72, as you can see in the second screenshot (I know I'm off on the B scale from solarized, doesn't matter). I tried different colors and Textmate never seems to render what I tell it to. The only thing I can think of is that it tries to match to a web-safe or other color set instead. Which probably means that all the solarized colors are off in Textmate.

So, what I think happened is that PR #21 switched the colors around to match spec (and look right in Sublime), but that the colors before PR #21 were a better match for Textmate. I'm really not sure what Textmate is doing with the colors, but if it's doing what I think it's doing, I think we should really look into forking off for Sublime, moving some contributions from Sublime users there, and reverting PR#21 (and perhaps some laters ones as well) for Textmate.

braver commented 11 years ago

Something else I checked, if I set the color using the color picker, picking the color from my Sublime window, it will set a background color for Textmate that matches the spec. However, when I look at the theme file that creates, the resulting hex value is #04202A, which is almost correct but darker: http://www.wolframalpha.com/input/?i=%2304202A. Again, my understanding of how this should work does not match what I see happening here. I have found (on Google) some mentions of people noticing this difference in rendering betweet Textmate and other editors, but since it's so subtle and noone really compares these things, I haven't found out why.

deplorableword commented 11 years ago

Good detective work, there's been a few pull requests about tweaking colours, I always though it was because I'd somehow screwed up in the beginning.

@Braver you don't happen to have a copy of TM1 kicking around do you? (I'm on a new machine) I wonder if those colours render differently as well?

braver commented 11 years ago

Nope, sorry, I only downloaded a trial version of TM2 to try this stuff out.