search

deplorableword / textmate-solarized

TextMate theme for Solarized
http://ethanschoonover.com/solarized
440 stars 98 forks source link

Figure out how to skin the gutter correctly #35

Open deplorableword opened 12 years ago

deplorableword commented 12 years ago

The latest build of TM2 has support for the gutter, if possible we should try and theme if accordingly https://github.com/textmate/textmate/pull/233

timhatch commented 12 years ago

I've just taken a look at this, with some guidance from @infininight as to how gutter theming has been implemented and will submit a pull request.

deplorableword commented 12 years ago

Cool, look forward to seeing it :)

On 9 October 2012 18:21, tim notifications@github.com wrote:

I've just taken a look at this, with some guidance from @infininighthttps://github.com/infininightas to how gutter theming has been implemented and will submit a pull request.

— Reply to this email directly or view it on GitHubhttps://github.com/deplorableword/textmate-solarized/issues/35#issuecomment-9270298.

Tom Martin twitter.com/deplorableword devart.org

timhatch commented 12 years ago

Tom,

I've pushed gutter modifications for the solarized-dark and solarized-light themes to the textmate/textmate-solarized repository. Although I now see that the textmate/textmate-solarized repository is technically a fork of this one...

I got a little confused at first by all the sublime-related issues/pull requests...

deplorableword commented 12 years ago

ah I see, right I'll try to pull this upstream from textmate/textmate-solarized :) Could you paste the commit hashes in this ticket?

Yes, sublime is apparently 100% compatible with TM themes, so as long as they don't mess with TextMate I'm happy to accept them.

timhatch commented 12 years ago

The commit hashes are: 200b8b9a530c4599e72650a33b5feb1a21b6b541 51661c737decb494f3fa14151252795ec0fb6871

I am aware that in principle Sublime recognizes Textmate themes and so yes, modifications to the core syntax highlighting within the theme files should work equally well in both applications. But equally the two applications appear to use the theme file for certain application-specific settings. e.g.

Textmate now has this concept of gutterSettings which so far as I know is unique to Textmate2 (so I guess will be ignored by Sublime); and

Sublime seems to have an additional editor concept of SublimeBracketHighlighter - which I hardly suppose is supported by Textmate/Textmate2

At the moment, the two editors are probably sufficiently close that these few divergent features aren't important, though I would have thought it more sensible to have a repository with the core syntax highlighting that is common between them and forks to deal with application-specific features. That would perhaps reduce the likelihood of future breakage.

But it's not my world :)

deplorableword commented 12 years ago

Yep I agree, if Sublime adds a bunch of stuff which is significantly different to TM then it should go into a fork :)

Thanks for the commit refs I'll pull those in and close when I'm done.

timhatch commented 12 years ago

@braver commented on the second of the above commits (51661c7) noting that it addresses an issue currently under discussion in Issue #15 of this repository and for which various people have different solutions, including pull request #39 (text selection highlighting).

I've looked at the issue more closely and replied (https://github.com/textmate/textmate-solarized/commit/51661c737decb494f3fa14151252795ec0fb6871#commitcomment-1990784) but you may wish to ignore 51661c7 until such time as there is a consensus solution