Closed braver closed 11 years ago
JodiWarren
commented
11 years ago The closing curly braces issue is with Sublime Text 2 - you have to open up Packages, go to CSS/CSS.tmLanguage, and then replace line 253 with the following:
<string>(\})</string>Hopefully that should help!
braver
commented
11 years ago I pulled in some color changes from @iristyle and made some changes to make it more consistent and less garish. You're right about the braces, I found the issue in their issue tracker... since there is no way to affect that right now I opted to change the theme into something consistent.
In light of recent discussion of color inconsistencies between TM and Sublime, I'm not gonna ask to pull this, but perhaps I can get some feedback on this (the files are in my fork)?
Iristyle
commented
11 years ago @braver Looks like an improvement to me for sure... not sure how I feel about the pink #id selectors, but everything else looks good to me.
I did see your comment earlier about doing an official fork for Sublime, and I think that sounds good. A number of my pulls are just hanging around w/out attention.
This is no way a shot at @deplorableword, but people get busy, and it seems like we have a few people hanging around that want Sublime specific features (support for extensions like SublimeLinter or BracketHighlighter, etc, etc)
I just setup a new GitHub organization and added you as an owner.
I'm going to push up the current state of my repo to this new repo, and we can start hacking over there. I will probably go ahead and get the url changed for package control to point to this new repo.
Contact me by email, and I'll give you the info for the shared gmail account I just created.
Iristyle
commented
11 years ago @braver The new fork is up... https://github.com/SublimeThemes/Solarized
Feel free to send your PRs that way now. I'll work on changing the URL in Package Control.
We'll need to update the README accordingly -- will get to that in a bit.
braver
commented
11 years ago Cool, I think that's the way to go. I'll move my stuff over there.
About the pink # selectors, I'm not so thrilled either, but I want them to stand out. I mean, why are there id's in your stylesheet in the first place? ;)
deplorableword
commented
11 years ago Hey @Iristyle yep have been a bit busy recently, glad we've managed to work it out so the sublime colour issue gets resolved :)
In terms of Sublime, does the app actually point to this repo? Would be good at some point to flip the switch so it tracks your fork instead.
deplorableword
commented
11 years ago Going to close this, if someone else thinks CSS looks messy please open a new Ticket
I put together a CSS test file (https://github.com/braver/solarized/blob/master/utils/tests/css.css), I'd love to have some feedback and perhaps additions to that before I ask to pull. It highlights a number of issues with the theme for CSS.
Some of the CSS3 stuff looks awful, especially the media queries. I have no clue as to why the closing curly braces should be red, and the parentheses seem inconsistent (I've seen blue, red and grey). It also kinda feels like it doesn't recognise the child selectors.