search

deplorableword / textmate-solarized

TextMate theme for Solarized
http://ethanschoonover.com/solarized
440 stars 98 forks source link

Please fix selection color in Solarized light #43

Closed yuriihabrusiev closed 10 years ago

yuriihabrusiev commented 11 years ago

'Selection' color must be the same as 'lineHighlight' - #EEE8D5, but it is #073642 https://github.com/deplorableword/textmate-solarized/blob/master/Solarized%20(light).tmTheme#L23

deplorableword commented 11 years ago

Pull requests are most welcome :)

Sent from my iPhone

On 20 Jan 2013, at 07:00 PM, Yuri Habrusiev notifications@github.com wrote:

'Selection' color must be the same as 'lineHighlight' - #EEE8D5, but it is #073642 https://github.com/deplorableword/textmate-solarized/blob/master/Solarized%20(light).tmTheme#L23

— Reply to this email directly or view it on GitHub.

albertboada commented 10 years ago

I agree something has to be wrong with the selection color in the Light theme, because it is quite disturbing the way it is.

'Selection' color must be the same as 'lineHighlight' - #EEE8D5, but it is #073642

Do we have any source confirming this? I'd gladly do the pull request.

albertboada commented 10 years ago

Well, i guess this is enough proof:

screen shot 2013-11-16 at 11 07 40 pm

Here goes the pull request...

albertboada commented 10 years ago

Since pull request #53 has been merged to master, this issue should be solved now. What do you think, @k3mm0tar ?

deplorableword commented 10 years ago

ps if any of you want to become formal contributors; just let me know :)

On Monday, 18 November 2013, Albert Boada wrote:

Since pull request #53https://github.com/deplorableword/textmate-solarized/pull/53has been merged to master, this issue should be solved. What do you think, @k3mm0tar https://github.com/k3mm0tar ?

— Reply to this email directly or view it on GitHubhttps://github.com/deplorableword/textmate-solarized/issues/43#issuecomment-28687765 .

Tom Martin twitter.com/deplorableword devart.org

albertboada commented 10 years ago

Not sure about what becoming a "formal contributor" involves, but I'd say no thanks, no offense! Although I will be trying to fix some PHP styles sometime soon (because I think they're pretty messed up right now), I can't be formally involved in this. I'll submit changes whenever I can, if I can, if they are welcome! :)

yuriihabrusiev commented 10 years ago

I use Sublime Text 3 and now it's ok. Thank you guys! :+1: