deplorableword / textmate-solarized

TextMate theme for Solarized

http://ethanschoonover.com/solarized

440 stars 98 forks source link

Add official Solarized color labels in comments #46

Closed Zearin closed 11 years ago

Zearin commented 11 years ago

Friendlier XML…

Now with comments!™

This is a small commit intended to make the reading the code faster and easier.

As far as TextMate is concerned, the files should be yield identical results.

The only changes are comments.

Summary of Changes

After each color, there is now a comment containing that color’s official Solarized name. (See [http://ethanschoonover.com/solarized/#the-values].)
There are several colors from outside the official palette. These colors’ comments are prefixed with (nonstandard) to clearly mark them as such. Additionally, their comment contains the closest official color, prefixed with a tilde. (E.g., a nonstandard color close to red is labelled .)

deplorableword commented 11 years ago

This is pretty rad so I'm going to merge it in, thanks for your help!

Zearin commented 11 years ago

@deplorableword You’re welcome! :)

Zearin commented 11 years ago

I realize some of the “off” colors are necessary.

However, in certain cases, I think the nonstandard colors actually outnumber the official ones. In other cases (red—I’m look at you…), there’s just a ridiculous number of different off-colors.

I don’t want to eliminate all nonstandard colors, because some of them allow for stuff like differentiating the gutter from the main background color.

That said—if I were to edit down the number of nonstandard colors, would you be open to a pull request?

deplorableword commented 11 years ago

Short answer: Yes

Long answer: Yes, if the red should be the sublime red then please go ahead and send a pull request. Obvs there will be a bunch of stuff that we need to add (gutters etc) so happy for those to be custom. To cut a long story short the off colours were down to a lot of pull requests from well meaning Sublime Text users who thought they were fixing the colours but were not :)

Zearin commented 11 years ago

To cut a long story short the off colours were down to a lot of pull requests from well meaning Sublime Text users who thought they were fixing the colours but were not :)

Oh, totally! No worries. When I noticed all the color variation, it was instantly clear how it happened. It’s a natural, normal part of the process.

I’d just like to clean it up a bit. ☺

(I’d better get started…!)

Zearin commented 11 years ago

Okay, got some changes for you! They’re in #47.