search

deplorableword / textmate-solarized

TextMate theme for Solarized
http://ethanschoonover.com/solarized
440 stars 98 forks source link

Replaced (most) nonstandard colors with official Solarized color values #47

Closed Zearin closed 11 years ago

Zearin commented 11 years ago

A small number of nonstandard colors remain. These were cases where I wasn’t certain what the color affected, or situations where the color is supposed to be slightly off—for example: the gutter, or the caret.

Although I can’t test these with every possible language, I’m pretty sure there shouldn’t be any issues with these changes. As I was working on this, it seemed to me that most of the nonstandard colors were simply an ad-hoc approximation, rather than a deliberate use of “slightly off” colors for situations like the above.

deplorableword commented 11 years ago

Hey,

Have you tried this in both TM1 and TM2?

Zearin commented 11 years ago

Oh! Nope. I only use TM2.

They are just colors, though. Like I said, I didn’t change a few of the off-colors if I thought they were intended to be “slightly off” (like gutters, invisible characters, etc).

deplorableword commented 11 years ago

Cool beans, I'll merge it in.

If you spot any other fixes from other forks in the network https://github.com/deplorableword/textmate-solarized/network feel free to give them a holla

Zearin commented 11 years ago

Thanks! :)

Just curious, but how long does it take changes in this repo to propagate to the “official” mirror under @textmate ?

deplorableword commented 11 years ago

Good question. Try poking whoever now maintains https://github.com/textmate/textmate-solarized and get them to pull upstream changes :)

Zearin commented 11 years ago

Good question. Try poking whoever now maintains https://github.com/textmate/textmate-solarized and get them to pull upstream changes :)

I can certainly do that.

But, couldn’t you open a Pull Request to that repo first? That way I can comment in the PR itself.