search

deplorableword / textmate-solarized

TextMate theme for Solarized
http://ethanschoonover.com/solarized
440 stars 98 forks source link

Add colorSpaceName to Solarized themes #48

Closed brief closed 9 years ago

brief commented 11 years ago

This should solve #33 in TM2.

deplorableword commented 11 years ago

Oh I didn't know it was possible to set a colour space, that's pretty interesting. So this forces TM to always use SRGB?

brief commented 11 years ago

Indeed. It's a fairly recent addition for themes (https://github.com/textmate/textmate/commit/d70ccc7cdf4750eed00672cff77ddf23f4e96251) that explicitly sets the color space to sRGB. Otherwise, Apple Generic RGB is used by default.

More details from Alan here: https://github.com/aziz/tmTheme-Editor/issues/15

Zearin commented 11 years ago

:+1:

I say merge! :)

jefffederman commented 10 years ago

Another vote for merging, it fixes color discrepancies (esp bgcolor) between Solarized dark in iTerm/vim, etc and TM2 (#33).

jibsen commented 10 years ago

:+1:

The Solarized palette is listed in sRGB on the homepage, so it appears lighter in TextMate. Adding this key should fix it (related post about the color space issue).