search

deployphp / action

GitHub Action for Deployer
MIT License
227 stars 46 forks source link

No output? #7

Closed amustill closed 3 years ago

amustill commented 3 years ago

Firstly, it's great to see an official action for Deployer.

However, I'm wondering if there is a reason behind the decision to suppress output from the commands? Personally, having used Deployer in other CI/CD environments, it's incredibly useful to see the output for debugging reasons.

I regularly use the --revision argument when deploying to non-production environments, so getting confirmation from Deployer of the revision used is super useful.

antonmedv commented 3 years ago

I didn’t get it) please explain

amustill commented 3 years ago

When using this action output from the commands are not logged to the workflow log. It simply runs silently, showing Run deployphp/action with no output from the command.

Attached is a screenshot showing the action running without any output logged - simply, I can't see what tasks are being run. Above you will see output from a composer install command, for example.

deployerphp-action

I believe this has to do with using execa and not piping the output back to the Node process.

antonmedv commented 3 years ago

Yes you are right. This should be fixed and output MUST be logged.

alies-dev commented 3 years ago

@amustill

I regularly use the --revision argument when deploying to non-production environments, so getting confirmation from Deployer of the revision used is super useful.

BTW, how to you specify a revision? I use deploy somehost --revision=$GITHUB_SHA -vvv but it doesn't resolve $GITHUB_SHA into a string (tried different approaches)

amustill commented 3 years ago

@lptn I too would use --revision="$GITHUB_SHA" but without output I cannot see how it resolves!

I'm currently only using this action on one project (I normally use GitLab CI/CD) so I haven't had the opportunity to fully test its capabilities.