search

deployphp / action

GitHub Action for Deployer
MIT License
222 stars 44 forks source link

Deployer 7.3.1 is missing in the manifest #71

Closed Seb33300 closed 1 year ago

Seb33300 commented 1 year ago

Deployer 7.3.1 is missing in the manifest file when using the deployer-version option: https://deployer.org/manifest.json

Also, this error is not triggered: https://github.com/deployphp/action/blob/06aeb295d6432970d615c5551e3d941e50349c46/index.js#L97-L99 You probably need to check for 'undefined' as well (not only null)

Here is the result:

    ...
    {
        "name": "deployer.phar",
        "sha1": "7fc18128545bebaa13fc7f3daa79b3e1fa67fd1e",
        "url": "https:\/\/github.com\/deployphp\/deployer\/releases\/download\/v7.3.0\/deployer.phar",
        "version": "7.3.0"
    }
]

100 29938  100 29938    0     0  32587      0 --:--:-- --:--:-- --:--:-- 32576
$ curl -LO undefined
curl: Remote file name has no length!
curl: (23) Failed writing received data to disk/application
Downloading "undefined".
Error: curl: Remote file name has no length!
Seb33300 commented 1 year ago

Duplicate of https://github.com/deployphp/action/issues/63

SimJoSt commented 3 months ago

Yes, it is related, but the other issue only tries to fix the problem with the action failing because the current version is not present in the manifest. To use the action with the newest version, the manifest should still be updated to contain the most current version.