search

deployphp / action

GitHub Action for Deployer
MIT License
222 stars 44 forks source link

Fix undefined check #73

Closed Seb33300 closed 6 months ago

Seb33300 commented 1 year ago

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/undefined#description

A variable that has not been assigned a value is of type undefined.

Fix error in https://github.com/deployphp/action/issues/63

SimJoSt commented 6 months ago

@antonmedv it would be great if you could provide a comment on why you closed this PR. It would help to create better contributions :) Was the code quality or approach not up to snuff? Is this approach superseded by another change? Maybe you want to focus on https://github.com/deployphp/action/pull/65?

antonmedv commented 6 months ago

Now sure what to say here.

SimJoSt commented 6 months ago

@antonmedv I would love to give back a little, try to provide PRs, report bug reports, and testing. If a PR is closed without a comment, I don't know what to make of it. Was it wrong? Broken? Unnecessary? Any hint, why it was closed would help. It could be, that the reason is obvious, and I am just blind. I can't figure it out without some help :)

Seb33300 commented 6 months ago

I think I forgot the typeof

SimJoSt commented 6 months ago

Ah, true. Could be. Well, that would be an easy fix.

antonmedv commented 6 months ago

It will be actually cool to refracture all this part more robust and include all the corner cases just type of could help but I’m not sure