`Invalid JSON in options` error when omitting the options input entirely

SimJoSt commented 6 months ago

When calling the deployer GitHub action without setting any values for the options input, the following error message appears: Invalid JSON in options It doesn't break the deployment, however an error message in a successful deployment log feels weird :) And with no actual problems occurring, I was wondering if the error detection is slightly off. I'm not familiar with the try-catch logic yet, so I cannot provide and improvement as a PR at this time.

Relevant code snippet: https://github.com/deployphp/action/blob/06aeb295d6432970d615c5551e3d941e50349c46/index.js#L116-L126

Readme section: https://github.com/deployphp/action/blob/06aeb295d6432970d615c5551e3d941e50349c46/README.md?plain=1#L26-L29

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Milkman337 commented 3 months ago

any update on this

tobz-nz commented 3 weeks ago

duplicate of #72

deployphp / action

`Invalid JSON in options` error when omitting the options input entirely #77

Upvote & Fund