deployphp / deployer

The PHP deployment tool with support for popular frameworks out of the box
https://deployer.org
MIT License
10.64k stars 1.49k forks source link

Add support for Symfony 4.0 #1437

Closed tehplague closed 6 years ago

tehplague commented 7 years ago
Q A
Issue Type Feature Request
Deployer Version 6.0
Local Machine OS N/A
Remote Machine OS N/A

Description

Now that Symfony 4.0 is released, let's try to make Deployer compatible with its Console component.

Cryde commented 6 years ago

We could already do some research like :

// Clear paths
set('clear_paths', ['web/app_*.php', 'web/config.php']); // <= no needed anymore

// Symfony shared files
set('shared_files', ['app/config/parameters.yml']); // <= no needed anymore / .env now !

// Assets
set('assets', ['web/css', 'web/images', 'web/js']); // <= old
set('assets', ['public/css', 'public/images', 'public/js']); // <= new 

For me the https://github.com/deployphp/deployer/blob/master/recipe/symfony3.php is ok ! :) Some stuff to adjust about symfony env variable I guess in : https://github.com/deployphp/deployer/blob/master/recipe/symfony.php

antonmedv commented 6 years ago

1420

zorn-v commented 6 years ago

@Cryde deploy:assets:install task not compatible with flex, as here https://github.com/deployphp/deployer/blob/6708d2640f9d8b68b539b3929d9b09cf0d4fec1e/recipe/symfony.php#L95 web is hardcoded

erik-ropez commented 6 years ago

Laravel 5.6 is out and it depends on Symfony 4.

solofeed commented 6 years ago

We have the problem with Symfony 4 support.

antonmedv commented 6 years ago

Done! 🎉

Shaked commented 6 years ago

@antonmedv is this really done?

AFAIK symfony now uses public/ instead of web/ and app/console is bin/console.

zorn-v commented 6 years ago

Use require/symfony4.php