Open Schrank opened 2 months ago
My intention was to not build anything on the remote host. composer install
is missing and could be added, but I'd call it locally for my use-case.
JS should be uploaded? Whole directory should be uploaded? deploy:update_code
should do that
Thanks for the quick answer! https://github.com/deployphp/deployer/blob/master/recipe/deploy/update_code.php doesn't contain any upload, maybe you are using https://github.com/deployphp/deployer/blob/master/contrib/rsync.php ?
Ah, hm.
Yes, I have overwritten 'deploy:update_code'
to use upload()
. But this function seems to be not really in wide use.
Question is, what is the goal of this recipe.
I have mainly used it to build locally and push that onto a remote server. If this is the goal, then I guess update_code should be replaced with rsync or something like that, such that the recipe works without overwriting tasks.
Building on the remote server, I'd actually try to achieve with shopware build-ins? Especially with the growing support of composer, it seems to me that the board means are there to achieve that and a deployer recipe is not necessary?
I have mainly used it to build locally and push that onto a remote server. If this is the goal, then I guess update_code should be replaced with rsync or something like that, such that the recipe works without overwriting tasks.
Yeap. Lets update the recipe.
Will take care of it. Have a working prototype, except the theme is not used on production 🤪
I'm currently trying the current shopware recipe and I think I'm missing something.
Three things I don't understand and would love to fix (therefore an issue an no discussion):
composer install
is not called and uploadedAm I missing something or is the recipe incomplete?
My current fix is to call composer install on the remote host and I ran theme:compile manually. If you explain to me how it is expected to work I'm happy to fix it - either the docs or the code :-)
cc @UlrichThomasGabor @peterjaap
Upvote & Fund