deployphp / deployer

The PHP deployment tool with support for popular frameworks out of the box
https://deployer.org
MIT License
10.52k stars 1.48k forks source link

Bump php/symfony dependencies or make it less strict #3867

Closed ITspirit closed 6 days ago

ITspirit commented 1 month ago

Bump Dependencies or make it less strict. Otherwise these tool will be blocked out for further usage.

Currently lot of dependencies are really selective, without need.

    "require": {
        "php": "^8.0|^7.3",
        "symfony/console": "^5.4.9",
        "symfony/process": "^5",
        "symfony/yaml": "^5"
    },

Why not make it less strict?

    "require": {
        "php": ">=7.3",
        "symfony/console": ">=5.4.9",
        "symfony/process": ">=5",
        "symfony/yaml": ">=5"
    },

So i could use it in projects with much modern dependencies.

Any concerns about this?

Upvote & Fund

Fund with Polar

martijn94 commented 1 month ago

We are running into issues with this as well.

antonmedv commented 1 month ago

Are you using dev-master branch? Please use tagged versions. Those don’t have any deps.

martijn94 commented 1 month ago

Are you using dev-master branch? Please use tagged versions. Those don’t have any deps.

I know it's a specific use case, but the problem arises for us when we include the project's composer autoloader in our deploy.php to be able to use some custom recipe's we published in our own composer packages.

This also loads a more recent version of symfony/console resulting in the following error for us:

PHP Fatal error: Declaration of Deployer\Component\PharUpdate\Console\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int

github-actions[bot] commented 6 days ago

This issue has been automatically closed. Please, open a discussion for bug reports and feature requests.

Read more: [https://github.com/deployphp/deployer/discussions/3888]