deployphp / deployer

The PHP deployment tool with support for popular frameworks out of the box
https://deployer.org
MIT License
10.65k stars 1.49k forks source link

Outdated phar available from deployer.org #3872

Closed mfickers closed 2 months ago

mfickers commented 3 months ago

I've recently switched to using the official Deployer GitHub Action, but this broke my deployment. The action will download Deployer as a .phar from deployer.org, while our old CI setup would instead install it via Composer (composer global require "deployer/deployer:~7").

I could trace the error back to a missing feature of the magento2.php recipe, that was initially introduced with Deployer 7.3.0. The GitHub Action will install Deployer 7.4.0, but the recipe seems to be outdated.

Steps to reproduce:

  1. Download https://deployer.org/releases/v7.4.0/deployer.phar
  2. Download https://github.com/deployphp/deployer/releases/download/v7.4.0/deployer.phar
  3. Extract both .phar files
  4. Compare magento2.php recipe

Expected behavior:

Actual behavior:

Upvote & Fund

Fund with Polar

antonmedv commented 3 months ago

Oh! This is strange. Ut what version is there?

mfickers commented 3 months ago

It looks identical to the file from version 7.1.3.

lamasfoker commented 3 months ago

I think this issue should be opened in deployphp/action repo. Anyway:

curl -LO https://deployer.org/releases/v7.4.0/deployer.phar
chmod +x deployer.phar
./deployer.phar --version
// Deployer 7.1.2

The v7.4.0 version is instead the v7.1.2

Why not just download the releases from GitHub?

curl -LO https://github.com/deployphp/deployer/releases/download/v7.4.0/deployer.phar
chmod +x deployer.phar
./deployer.phar --version
// Deployer 7.4.0
github-actions[bot] commented 2 months ago

This issue has been automatically closed. Please, open a discussion for bug reports and feature requests.

Read more: [https://github.com/deployphp/deployer/discussions/3888]