deployphp / distribution

Deployer Phar Distribution
30 stars 9 forks source link

Deployer ignores overriden default deploy task commands #21

Closed iammati closed 2 years ago

iammati commented 2 years ago

Upgrade without issues from v6.8 to v7.0.0-rc.4 with PHP 8.1.3 but I've noticed that the following snippet:

// Main
task('deploy', [
    'deploy:info',
    'deploy:prepare',
    'deploy:lock',
    'deploy:release',
    'deploy:update_code',
    'deploy:unlock',
    'deploy:shared',
    'deploy:vendors',
    'deploy:symlink',
    'typo3:finish',
    'deploy:unlock',
    'deploy:cleanup',
])->desc('Deploy your project');

Is being ignored by deployer and it executes instead the following commands: image

And runs into a locked-state. Note that right after update_code it should actually "force" unlock - testing purpose since I was wondering why I kept run into a locked state.

Any ideas to this?

antonmedv commented 2 years ago

Please provide full deploy.php. Also run dep tree deploy and dep deploy --plan, attach outputs.

iammati commented 2 years ago

@antonmedv image image

antonmedv commented 2 years ago

So both 'deploy:prepare' and 'deploy:lock' has lock task in it.

iammati commented 2 years ago

Oh that fixed it. Does deploy:prepare performs since v7 automatically a lock? Had to use that at least in v6

antonmedv commented 2 years ago

It's new API, all other recipes uses prepare as well.