search

depoio / node-telegram-bot

Client wrapper for Telegram Bot API (Under heavy development)
MIT License
136 stars 30 forks source link

Add new getFile API #47

Closed pennyfx closed 8 years ago

pennyfx commented 8 years ago

https://core.telegram.org/bots/api#getfile

sebastianarena commented 8 years ago

+1 for this!

shernshiou commented 8 years ago

@pennyfx @kaminoo in the pipeline

shernshiou commented 8 years ago

@pennyfx @kaminoo I have committed an experimental getfile feature. Please go ahead and try it out

ee25c1f942e834421c0c68fe3e12de29ccce0dc7

sebastianarena commented 8 years ago

@shernshiou awesome! Will try it out soon! Thanks!

sebastianarena commented 8 years ago

@shernshiou I've taken a look at the implementation you did. I would suggest that the getFile method you did saves the file locally only as an alternative. I see you library as a means of creating something bigger. In my case for example, I have no need to download the file but to transfer the URL to someone else. Could you add that?

shernshiou commented 8 years ago

@kaminoo sure.

Any opinion on my latest commit? 91ac92f41db495a48dfc4f1de7383859d33adecb