search

deprecate / electric-base-components

⚡ UI Components for Electric
https://npmjs.com/electric-base-components
0 stars 3 forks source link

ElectricCodeTabs: clicking already selected tab scrolls to top of page #7

Open robframpton opened 7 years ago

robframpton commented 7 years ago

I noticed on http://wedeploy.com/docs/auth/getting-started.html that if Javascript is already selected and I click on it, it will scroll to the top of the page.

@fernandosouza do you mind taking a look into this?

fernandosouza commented 7 years ago

Sure!

zenorocha commented 7 years ago

Nice catch! Semantically speaking that should be a <button> not an <a>.

fernandosouza commented 7 years ago

Yes, Zeno. It should be a button.

I'm using the metal-tabs to render it.