search

deprecate / generator-electric

⚡ Yeoman Generator for Electric
https://npmjs.com/generator-electric
2 stars 9 forks source link

Senna navigation doesn't work with HTTPS #31

Closed pragmaticivan closed 7 years ago

pragmaticivan commented 7 years ago

The links shows as https, but the request is going with only http. I get navigation errors after that.

pragmaticivan commented 7 years ago

@ygorcosta, @zenorocha this one is pretty critical.

pragmaticivan commented 7 years ago
screen shot 2017-04-03 at 7 47 02 pm
pragmaticivan commented 7 years ago

Just tested again with the new version. Still happening. I created this one from scratch.

eduardolundgren commented 7 years ago

Senna does support HTTPS, see https://github.com/liferay/senna.js/pull/157. Electric might be doing something that breaks the functionality.

fernandosouza commented 7 years ago

This happens because the link to the page that should be loaded is not using https protocol. https://developer.mozilla.org/en-US/docs/Web/Security/Mixed_content/How_to_fix_website_with_mixed_content

I've just created a new electric project and I've seen that links there are relative, it should work.

zenorocha commented 7 years ago

Fixed on https://github.com/liferay/senna.js/commit/cf155d41ebe70a7813a090729d1b67e2d5859879