deprecate / metal-clay-components

10 stars 14 forks source link

Add elementClasses and id and some fixes #171

Closed matuzalemsteles closed 6 years ago

matuzalemsteles commented 6 years ago

Just adding support for elementClasses andid components as a guide to good practice discussed in #144.

Problems

The use of dataAttributes to pass custom attributes is not possible because of SoyToIncrementalDomSrcCompiler that does not support variables to transforms into attributes. See #144.

carloslancha commented 6 years ago

Just started reviewing :)

:octocat: Sent from GH.

carloslancha commented 6 years ago

Resent https://github.com/metal/metal-clay-components/pull/172