search

deprecate / metal-clay-components

10 stars 14 forks source link

[DO NOT MERGE] Merge Clay into Clay-Components #185

Closed jbalsas closed 6 years ago

jbalsas commented 6 years ago

Hey guys, this is an initial step to merge together https://github.com/liferay/clay and https://github.com/metal/metal-clay-components into one.

Since this is already a lerna repo, it's impossible to directly import it into clay directly, so I took the other way around, meaning that we are here importing every commit from that repo and putting it into packages/clay. After this is completed, we will probably need forcibly replace all history in https://github.com/liferay/clay with this one...

The cool thing now is that changes in packages/clay are automatically available locally linked for any other component in this repo. We can start collaborating closer and analyzing how different changes might affect our components. We can also start considering what type of distribution mechanism we want (claycss.zip with css and components...). Finally, we can do synced releases as a whole.

I'm reaching out to @pat270, @Robert-Frampton, @carloslancha, @matuzalemsteles and @marcoscv to provide some input, since this might impact your workflows for a little while :S

jbalsas commented 6 years ago

(I see I might need to rebase on my own, but this is good to at least start the conversation)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 84.325% when pulling a8697d25e3ebf6df777bf1db7727575650b62a02 on feature/lerna into aee0dc6ad262f28b21fda55f1c714f1b213a2107 on master.

jbalsas commented 6 years ago

@pat270, can you list the usual tasks you used to perform so I can double check they work the same in this layout for now? Like, release, site update, publish, git flow...

pat270 commented 6 years ago

@jbalsas build, serve, release, toc

jbalsas commented 6 years ago

Cool, I'll take a look and work out some of the lateral issues before continuing with this!