search

deprecate / metal-clay-components

10 stars 14 forks source link

Improve ClayComponent tests #200

Closed carloslancha closed 6 years ago

carloslancha commented 6 years ago

This resolves https://github.com/metal/metal-clay-components/issues/144

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.07%) to 84.656% when pulling cd0179ed83f9f3b0f7d5f6d689e7194d77466030 on carloslancha:DataAttributes.2 into 86d46208e7416f2070b9666fd816cf9e32bcb9d3 on metal:master.

carloslancha commented 6 years ago

@matuzalemsteles this should resolve what you said about data-senna-off

matuzalemsteles commented 6 years ago

Hey @carloslancha, I like the idea of having a component to centralize common behaviors. What do you think of this package if call shared and not make this package public, it is necessary to make it available? we could add things in common that we have between more than one package, something like facebook uses react. Just a thought to know if this fits into our reality.

jbalsas commented 6 years ago

Hey @matuzalemsteles, we probably want to expose ClayComponent as consumers will probably want to build on top of that if they are using Clay.

I'll merge ahead so I can do a quick release in sync with the latest clay one, but keep the discussion going, figure out what else could be abstracted away here and apply to the rest of the components whenever you can!