search

deprecate / metal-clay-components

10 stars 14 forks source link

Update markups and fix #234

Closed matuzalemsteles closed 6 years ago

matuzalemsteles commented 6 years ago

hey @carloslancha, ClayUserCard customize the label of ClaySticker mean that we are duplicating the markup, but it is obliged to use the sticker-overlay class in the label to be positioned correctly, we can add as default in ClaySticker but I do not know what effects it can cause it being used on other components. What do you think about this?

This pr was tested with #233.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.04%) to 83.144% when pulling ce0e803dba313c698dd36dae4733be8c190700b6 on matuzalemsteles:update-markup into 7e67869f83454226e8587b4c8ca32f903c730674 on metal:master.

carloslancha commented 6 years ago

Just started reviewing :)

:octocat: Sent from GH.

carloslancha commented 6 years ago

Resent https://github.com/metal/metal-clay-components/pull/237