search

deprecate / metal-clay-components

10 stars 14 forks source link

Update ClayButton markup #236

Closed matuzalemsteles closed 6 years ago

matuzalemsteles commented 6 years ago

It is necessary that do not add a span when you just want to render an icon, this causes some unwanted behaviors in some components like ClayLabel.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.03%) to 83.139% when pulling 56f186760fd0dee22eb808f1a1461c0b2c9e0c96 on matuzalemsteles:markup-button into a3db8744bcf8d0e118cd13125dbba58a0ff403fa on metal:master.

carloslancha commented 6 years ago

Just started reviewing :)

:octocat: Sent from GH.

carloslancha commented 6 years ago

Resent https://github.com/metal/metal-clay-components/pull/238