search

deprecate / metal-clay-components

10 stars 14 forks source link

Update ClayTable, ClayList and ClayCardGrid schemas. Add plus button as a dropdown feature to Management Toolbar #254

Closed carloslancha closed 6 years ago

matuzalemsteles commented 6 years ago

Just started reviewing :)

:octocat: Sent from GH.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.3%) to 81.026% when pulling a05cbf2312034c167493d198369793e4aef97a28 on carloslancha:ClayManagementToolbar.features.2 into 272261173a8e13dc87aaef4d176e7588ad623939 on metal:master.

matuzalemsteles commented 6 years ago

Just started reviewing :)

:octocat: Sent from GH.

carloslancha commented 6 years ago

@matuzalemsteles nice catch!

FYI: It was a bug caused by the creation of ClayDropdownItem component. I didn't realize that component was rendering, in some cases like in the separator true one, more than one element, and each complete component (the output of the .render template) can only render one element, all nodes after that are ignored.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.05%) to 81.279% when pulling a437985752a3b350d5cf8e0c14cafa26e3401b16 on carloslancha:ClayManagementToolbar.features.2 into 272261173a8e13dc87aaef4d176e7588ad623939 on metal:master.