Closed carloslancha closed 6 years ago
Hey @matuzalemsteles! Here I've tried to make all of the rendering in soy to make possible server-side rendering. Take a look and tell me your thoughts;)
Hey @matuzalemsteles, I'm going to merge this because I want to push forward with the clay reunification, so this is likely to be the last PR in this repo before we move everything to http://github.com/liferay/clay
hey @carloslancha, Good job with rendering on SSR. But just pointing out a few points.
When we reach more than 6 pages and currentPage
is the last page, the range ends up adding more than it should.
We may have to trigger some events when there are clicks on the items.
Will we let SPA always load pages when there is user interaction or are we going to give the possibility that devs will load the data when events are triggered? since it can gain some "performance" ... Using the events triggered by pagination.
What do you think?
Hey @matuzalemsteles I'll take a look on that bug, didn't notice, thx!
I've preferred for now not to add those events till we need it. We can easily add it in the future.
EDIT: Fixed here https://github.com/metal/metal-clay-components/pull/265