deprecate / metal-clay-components

10 stars 14 forks source link

Create ClayPagination and ClayPaginationBar #263

Closed carloslancha closed 6 years ago

carloslancha commented 6 years ago
captura de pantalla 2018-01-13 a las 18 01 57
coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.02%) to 81.306% when pulling 1a6d3906b408589f00f4fee5516fe9aafa89c17a on carloslancha:ClayPagination into eb105d426001581183374682c4700afe586d51db on metal:master.

carloslancha commented 6 years ago

Hey @matuzalemsteles! Here I've tried to make all of the rendering in soy to make possible server-side rendering. Take a look and tell me your thoughts;)

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 81.618% when pulling fa6eb4d68608d6362c26cda2d6a4de939e255b64 on carloslancha:ClayPagination into eb105d426001581183374682c4700afe586d51db on metal:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 81.618% when pulling 009a98a247b7176027d334412c67e98a3ff01281 on carloslancha:ClayPagination into 371d3b887121d5d01b9687dcd15f0bf210be44e6 on metal:master.

jbalsas commented 6 years ago

Hey @matuzalemsteles, I'm going to merge this because I want to push forward with the clay reunification, so this is likely to be the last PR in this repo before we move everything to http://github.com/liferay/clay

matuzalemsteles commented 6 years ago

hey @carloslancha, Good job with rendering on SSR. But just pointing out a few points.

What do you think?

carloslancha commented 6 years ago

Hey @matuzalemsteles I'll take a look on that bug, didn't notice, thx!

I've preferred for now not to add those events till we need it. We can easily add it in the future.

EDIT: Fixed here https://github.com/metal/metal-clay-components/pull/265