search

deprecate / metal-uri

Class for parsing and formatting URIs.
Other
3 stars 7 forks source link

substitute test description to make it more specific #16

Closed vbence86 closed 7 years ago

vbence86 commented 7 years ago

Intent

To dispel confusion about against what the affected test case is executed.

jbalsas commented 7 years ago

Hey @vbence86, isn't there anything else that could make it fail? Are there no other types of invalid urls we should catch? Maybe we're just missing more cases so the name isn't confusing anymore? 😉

vbence86 commented 7 years ago

Yes, I agree on that it'd be better off aiming for better coverage of eventualities. I'm happy to pick it up and augment the unit tests with further individual cases. My proposal is to keep the assertion as tiny as possible so that when it fails it can be captured easily as opposed to one big function that incorporates numerous assertions.

The only question I've still got is whether we want to go down this road of utilizing the parseFromAnchor functionality. The result of altering an href attribute can vary greatly across platforms and browsers, hence the failing tests currently.

Please advise me on the foregoing concern.

I've added a screenshot that describe my concerns further:

captura de pantalla 2017-08-22 a las 12 55 34