add more thorough check for invalid URIs

deprecate / metal-uri

Class for parsing and formatting URIs.

Other

3 stars 7 forks source link

add more thorough check for invalid URIs #17

Closed vbence86 closed 7 years ago

vbence86 commented 7 years ago

Disclaimer

FF and IE appear to have implemented the built-in native URI parsing logic differently than the project'sparseFromAnchor helper function expects and subsequently invoking this function with invalid URIs results in failing tests.

Intent

To fix failing tests with FF and IE

Solution

Added more sophisticated checks against validating the URI with virtual <a> element.

Tested

IE
FF
Safari
Chrome

jbalsas commented 7 years ago

Hey @vbence86, this is looking good! Can you please rebase this on top of https://github.com/metal/metal-uri/tree/travis so we can see it running in travis?

vbence86 commented 7 years ago

The rebase is captured in the following PR: https://github.com/metal/metal-uri/pull/18. This also achieves a "green" build, so I gather this PR can be closed.