search

deprecated-packages / reveal-src

Static analysis for your templates is here!
9 stars 3 forks source link

Scoper #29

Closed lulco closed 2 years ago

lulco commented 2 years ago

Symplify classes probably shouldn't be prefixed. I've got several errors like Service of type RevealPrefix20220606\Symplify... not found. Did you add it to configuration file? But also Service of type Reveal\LattePHPStanCompiler\LatteToPhpCompiler: Service of type RevealPrefix20220606\Latte\Parser required by $latteParser in LatteToPhpCompiler::__construct() not found. Did you add it to configuration file?

All classes used as services should stay with original names, right?

I can try to prepare PR to scoper.php. It's about adding some exclude-namespaces isn't it?

TomasVotruba commented 2 years ago

Only the Symplify classes that are part of public API should not be prefixed. Otherwise, yes. What such classes do you use?

Possibly related to https://github.com/revealphp/reveal/issues/3

lulco commented 2 years ago

I'm using Symplify\Astral\Naming\SimpleNameResolver and Symplify\Astral\NodeValue\NodeValueResolver. They are used also directly in reveal packages

TomasVotruba commented 2 years ago

The "Symplify\Astral" should be exlcuded then.