search

deprecated-packages / symplify

[DISCONTINUED] Check split packages in their own repositories :)
MIT License
621 stars 189 forks source link

[Statie] Naming - related_posts vs similarPosts filter. #386

Closed integer closed 7 years ago

integer commented 7 years ago

Statie has related_posts for defining connected posts. But when you prepare your template, you have to use similarPosts filter. This behavior is well documented, but still a little bit confusing.

Do you have some reason for this different naming or it is some kind of legacy?

TomasVotruba commented 7 years ago

Thanks for this question.

It the legacy residuum, becuase at first the similarity was compute by algorithm. Now it's related posts, picked by user.

I think relatedPosts would be better now. What do you think?

integer commented 7 years ago

Thanks for your reply.

Filter name relatedPosts would be better. But similarPosts should works for backward compatibility too. It's not bug, just name tweaking.

May I prepare PR?

TomasVotruba commented 7 years ago

But similarPosts should works for backward compatibility too. It's not bug, just name tweaking.

That makes sense. It can be removed on Symplify 3.0 then

May I prepare PR?

That would be great