search

deprecated-packages / symplify

[DISCONTINUED] Check split packages in their own repositories :)
MIT License
618 stars 188 forks source link

[PHPStanRules] Merge ForbiddenProtectedPropertyRule and NoProtectedElementInFinalClassRule to NoProtectedClassElementRule #4525

Closed TomasVotruba closed 1 year ago

enumag commented 1 year ago

@TomasVotruba I was using NoProtectedElementInFinalClassRule but not the other rules. Is there a way to restrict the new rule to final classes? The new rule is too restrictive for our project.

TomasVotruba commented 1 year ago

No, that's not possible. I've found only 1 exception in our projects. The rules overlapped in 99 % cases, so they were merged.

The goal is exactly to avoid those properties you describe.

enumag commented 1 year ago

The new rule also report protected properties in non-final classes where I still want to use them for the time-being.