deprecated-packages / symplify

[DISCONTINUED] Check split packages in their own repositories :)
MIT License
621 stars 189 forks source link

[Statie] HTML files are silently removed from source subdirectory #638

Closed tomasfejfar closed 6 years ago

tomasfejfar commented 6 years ago

How to reproduce:

Expected:

Actual:

TomasVotruba commented 6 years ago

I see, thanks for clear example.

From top of my head, I would try add .html to static files here: https://github.com/Symplify/Symplify/blob/7d2b7a1945af09e38fb1e32183c45f6afc00f7dc/packages/Statie/src/FileSystem/FileFinder.php#L14

and remove from here: https://github.com/Symplify/Symplify/blob/7d2b7a1945af09e38fb1e32183c45f6afc00f7dc/packages/Statie/src/FileSystem/FileFinder.php#L69

*.html files should be static with no modification.

Btw, what exactly do you need this for? Gradual migration of plain-html website?

tomasfejfar commented 6 years ago

I have a static site for our wedding in the subdirectory, that does not need to be handled by statie.

tomasfejfar commented 6 years ago

In the end I worked around it with a simple hack.

TomasVotruba commented 6 years ago

:+1:

I've "found the digged dog" in the meantime :)

All files that end with "index.html" are moved to root as "index.html" and the last wins.

https://github.com/Symplify/Symplify/blob/da50836122abb9d47a500355f244c8fcc5b6275d/packages/Statie/src/Renderable/RouteFileDecorator.php#L73-L77

WIP

tomasfejfar commented 6 years ago

Thx