hyesungoh commented 1 year ago

🤔 해결하려는 문제가 무엇인가요?

closes #133

🎉 어떻게 해결했나요?

자연스러운 로딩 핸들링 (로딩 컴포넌트의 exit 애니메이션 재생) 을 위해 개발했어요
- suspense는 exit 애니메이션 재생이 안되더라구요 그래서 이렇게 만들어 사용하곤 했었어요

사용 방법은 다음과 같아요

 const {data, isLoading} = useQuery();

 return (
  <LoadingHandler isLoading={isLoading} fallback={<SomeSpinner />}>
    {data}
  </LoadingHandler>
 )

다른 우아한 방법 공유해주시면 감사하겠습니다 !!

📚 Attachment (Option)

cloudflare-pages[bot] commented 1 year ago

Deploying with Cloudflare Pages

Latest commit:	`58f17ab`
Status:	✅ Deploy successful!
Preview URL:	https://936c907d.12-team3-web.pages.dev
Branch Preview URL:	https://issue-133.12-team3-web.pages.dev

View logs

github-actions[bot] commented 1 year ago

Bundle Sizes

Compared against 340ea7171a07a281032be401e5dc6c08de51a4b0

Route: No significant changes found

Dynamic import: No significant changes found

codecov-commenter commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (58f17ab) compared to base (340ea71). Patch has no changes to coverable lines.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #140 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 21 21 Lines 191 191 Branches 37 37 ========================================= Hits 191 191 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hyesungoh commented 1 year ago

아직 상상코딩이긴한데 axios intercepter를 이용해서 로딩 심는건...그럼 모든 axios 요청에 로딩 보여줄수 있지않을까 생각하는데 실제 개발하면 어떤 이슈랑 문제점이 있을지 몰라서 일단 끄적여만 봅니다.

오호 상상코딩천재 👍 react-query를 안쓴다면 그렇게도 할 수 있겠네요 ! 👍 👍

근데 리액트 쿼리에서 isLoading을 제공해줘서 괜찮을듯 !! https://tanstack.com/query/v4/docs/adapters/react-query

depromeet / ahmatda-web