depromeet / ahmatda-web

아맞다 :white_check_mark: 이젠 까먹지 말고 챙기자

https://github.com/depromeet/ahmatda-web#download

7 stars 0 forks source link

사용자 카테고리 Mutation 적용 #171

Closed hyesungoh closed 1 year ago

hyesungoh commented 1 year ago

🤔 해결하려는 문제가 무엇인가요?

close #162, close #161
사용자 카테고리 삭제
국지적으로 사용되고 있던 Graphic type 과 Category Kind type

🎉 어떻게 해결했나요?

국지적으로 사용되고 있던 Graphic type을 src/components/graphics/type을 기준으로 통일했어요
백엔드에서 사용되는 Category type을 Category Kind라는 이름으로 대응했어요
- 송수신되는 값은 영어이지만, 렌더링되어야하는 값은 한글이라 오브젝트 형식으로 대응했어요
- 상태 관리 또한 영어로 하고, 화면에 그려져야하는 부분에서 오브젝트를 사용하도록 했어요
관련해서 Object.keys() 의 타입이 string[]이 되는 문제를 해결하고자 objectKeys 유틸을 만들었어요
사용자 카테고리에 대한 mutation을 담는 useUserCategoryMutation hook을 만들었고 사용했어요

📚 Attachment (Option)

github-actions[bot] commented 1 year ago

Bundle Sizes

Compared against 62263dd8a245712975e6518d323247a5f41ab928

Route	Size (gzipped)	Diff
`/template`	90.77 KB	-1.42 KB

Dynamic import	Size (gzipped)	Diff
`../components/route-home/category/CategorySection.tsx -> ./CategorySettingBottomSheet`	10.6 KB	+6.43 KB

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with Cloudflare Pages

Latest commit:	`7bbd015`
Status:	✅ Deploy successful!
Preview URL:	https://5ad8e90a.12-team3-web.pages.dev
Branch Preview URL:	https://issue-161.12-team3-web.pages.dev

View logs

codecov-commenter commented 1 year ago

Codecov Report

Base: 98.60% // Head: 98.61% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (7bbd015) compared to base (62263dd). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #171 +/- ## ======================================= Coverage 98.60% 98.61% ======================================= Files 23 23 Lines 215 216 +1 Branches 45 45 ======================================= + Hits 212 213 +1 Misses 3 3 ``` | [Impacted Files](https://codecov.io/gh/depromeet/ahmatda-web/pull/171?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet) | Coverage Δ | | |---|---|---| | [src/utils/utils.ts](https://codecov.io/gh/depromeet/ahmatda-web/pull/171/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet#diff-c3JjL3V0aWxzL3V0aWxzLnRz) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hyesungoh commented 1 year ago

리뷰 이후에 빌드 안되는 문제 해결해서 머지할게요 !

현재 main에 작성된 내용과 변경점에 있어서 타입이 안맞는 이유때문에 빌드가 안되네요 !