depromeet / ahmatda-web

아맞다 :white_check_mark: 이젠 까먹지 말고 챙기자
https://github.com/depromeet/ahmatda-web#download
7 stars 0 forks source link

템플릿 및 소지품 인터페이스 정의, [탐색] mock 데이터 업데이트, query hook 추가 #172

Closed eunddodi closed 1 year ago

eunddodi commented 1 year ago

🤔 해결하려는 문제가 무엇인가요?

🎉 어떻게 해결했나요?

📚 Attachment (Option)

eunddodi commented 1 year ago

전.. API 없는 쉐도우복싱을 멈추고 만든 사람 페이지 만들러 갑니다 🧚‍♀️

github-actions[bot] commented 1 year ago

Bundle Sizes

Compared against 445fa59cbd0159d176e9e6fc65a2f7ef7d3a742c

Route Size (gzipped) Diff
/template 92.18 KB +6.51 KB

Dynamic import: No significant changes found

codecov-commenter commented 1 year ago

Codecov Report

Base: 100.00% // Head: 98.55% // Decreases project coverage by -1.44% :warning:

Coverage data is based on head (8875002) compared to base (445fa59). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #172 +/- ## =========================================== - Coverage 100.00% 98.55% -1.45% =========================================== Files 21 22 +1 Lines 192 207 +15 Branches 37 41 +4 =========================================== + Hits 192 204 +12 - Misses 0 3 +3 ``` | [Impacted Files](https://codecov.io/gh/depromeet/ahmatda-web/pull/172?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet) | Coverage Δ | | |---|---|---| | [src/components/checkbox/CheckboxGroup.tsx](https://codecov.io/gh/depromeet/ahmatda-web/pull/172/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet#diff-c3JjL2NvbXBvbmVudHMvY2hlY2tib3gvQ2hlY2tib3hHcm91cC50c3g=) | `100.00% <100.00%> (ø)` | | | [src/components/button/ContainedButton.tsx](https://codecov.io/gh/depromeet/ahmatda-web/pull/172/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet#diff-c3JjL2NvbXBvbmVudHMvYnV0dG9uL0NvbnRhaW5lZEJ1dHRvbi50c3g=) | `72.72% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=depromeet)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

eunddodi commented 1 year ago

👍 👍 💯

저는 줄임말 안티팬이라 Recommned를 다 썻을 거 같은데 쓰신 거 보니까 더 지적인 표현 같군요 .... 🥇

저도 그걸 써보려고 했는데... recommendation은 길이가 선을 좀 넘길래 줄여버렸습니다