search

deps-rs / deps.rs

Keep your dependencies up-to-date
https://deps.rs
Apache License 2.0
426 stars 26 forks source link

error: expected comma after minor version number, found '-' #114

Open cberner opened 3 years ago

cberner commented 3 years ago

I use deps.rs with my project https://github.com/fleetfs/fleetfs, and the badge has been failing. I ran deps.rs locally and found that the error message is "error: expected comma after minor version number, found '-'".

I haven't been able to determine the cause of this, but I created a minimal repro: https://github.com/cberner/depsrs-bug, which you can see fail: https://deps.rs/repo/github/cberner/depsrs-bug

paolobarbolini commented 3 years ago

Thanks for taking the time to create a minimal repro.

The issue is with semver 1.0 tightening it's rules to only support cargo's interpretation of semantic versioning. raft 0.5.0 specified an invalid version requirement for protobuf, and because deps.rs parses all releases of a crate, querying any raft version fails because of 0.5.0 having the semver issue.

This issue has already happened multiple times in the past https://github.com/rust-lang/crates.io/issues/2463, so deps.rs will have to change in order to ignore bad releases instead of failing the entire dependency tree analysis.