search

deptagency / algomart

Algorand NFT Storefront platform
https://demo.algomart.dev/
MIT License
183 stars 79 forks source link

Video Preview Upload Fails #12

Open brandonaaskov opened 3 years ago

brandonaaskov commented 3 years ago

Overview

I tried uploading a preview video for an NFT that was very large for something like that and got an error but could only discover what it was after digging into the network requests: https://share.brandonontheinternet.com/X6ub9oZR

To reproduce

Steps to reproduce the behavior:

  1. Go to the CMS
  2. Create an NFT Template
  3. Try to upload a video to the CMS that's too big
  4. See error

Expected behavior

It uploads the video or tells me in the UI that the file is too large.

brandonaaskov commented 3 years ago

This is also true for uploading to the "Asset File", not just the preview image.

smonn commented 3 years ago

Ping @kevlarr. To avoid me staring myself blind at Directus code, is there a configurable file size upload limit (or request size limit) in Cloud Run or baked into the CMS docker image? FWIW, large uploads work fine both when running Directus locally and also when uploading large files in the Firebase Storage console.

kevlarr commented 3 years ago

@smonn AFAIK the load balancers fronting Cloud Run services have a 32MB request limit if HTTP1, but no such limit if HTTP2 (which I think would be a question for Directus..?). I don't think there would be an issue with the GCS bucket storage itself.