See listing of NFT for sale in marketplace

davidjmurphyjr commented 2 years ago

Below are some scoping notes I'd like to review with you, @smonn

Edit: Clarification from review with Simon (marked with emoji)

Listings

Collectible == NFT? ✅

Confirming: No public access to Collectibles, to access...

Own it
It is listed? ❌ Not confirmed, actually the public is allowed access to any and all Collectible records similar to how the blockchain is publicly viewable.

Assuming: Need to own Collectible to list it ✅

FK algomart-api.public.CollectibleOwnership? ❌ CollectibleOwnership stores history of ownership -- can get current owner from Collectibles.ownerId

Is there anything stopping a brand from listing a Collectible directly

i.e. sell an individual NFTs (instead of pack of one)?
if so, not a strictly "secondary" or "resale" market
is there such a thing as new vs used -- minter, first owner after minted? 👉 Brands will not be allowed to list NFTs directly, they can only sell packs. 👉 strictly a secondary market 👉 marketplace does not use circle

Always an auction ✅

Out of scope: "buy it now", "classified", "fixed price" type listing ✅

Listing Fields

CollectibleOwnershipId ❌ CollectibleOwnership stores history of ownership -- can get current owner from Collectibles.ownerId
AuctionStart: DateTime
DurationHours: int
- or AuctionEnd: DateTime
Reserve: {Amount: decimal, Currency: Currency}
Description: string
- 👉 AppId (smart-contract ref)

Bid Fields

ListingId
Created: DateTime
Amount: {Amount: decimal, Currency: Currency}
UserAccountId

TODO: Code that takes a listing and bids and outputs Activity entries 👉 Consider using a discrete endpoint in the API that returns list of activity, feature is below the fold, could be lazy-loaded

smonn commented 2 years ago

URLs

For the marketplace pages

/marketplace/auctions - for all listings /marketplace/auctions/:collectibleAuctionId - for single listing

For later usage to view any NFT in the AlgoMart site

Option 1

/nft/:collectibleTemplateId - for collectible template /nft/:collectibleTemplateId/:assetId or /nft/:collectibleTemplateId/:edition - for single nft

Option 2

/nft/:assetId - for single nft

davidjmurphyjr commented 2 years ago

I'm trying to reuse the pack auction components where it makes sense. To figure out where it makes sense, I'm comparing the existing implementation of pack auction (pictured below) with the pack auction Figma and the marketplace auction Figma. I talked with Nat, the Figmas were never finished, they have inconsistencies, need a review and some more design time. I'd imagine the pack auction implementation is not final either.

@smonn how would you like me to proceed, put this on hold until the Figmas are final or continue using the draft Figmas and my best judgement?

TODO

[ ] Add "Listed by" profile pic and username to collectible auctions, do not add to pack auctions
[ ] Add Remind Me functionality on upcoming auction
- https://www.figma.com/file/hkoiAU61jBPuJy0jESAXrl?node-id=2504:7117#144162264
[ ] Add Activity to both pack and
[ ] For an upcoming auction, maybe Reserve Price should say set instead of met.
- What is the inverse set, N/A?, not set?
- https://www.figma.com/file/hkoiAU61jBPuJy0jESAXrl?node-id=2504:7117#143893641
[ ] Winning Bid field doesn't make sense for an upcoming auction, replace or remove?
[ ] Auction begins, remind me on pack listing?
- https://www.figma.com/file/hkoiAU61jBPuJy0jESAXrl?node-id=2504:7117#144162264

deptagency / algomart