search

deptagency / dept-engineering-blog-ui

dept-engineering-blog-ui.vercel.app
MIT License
1 stars 3 forks source link

Feature Removal: StickyNav #41

Closed nring closed 2 years ago

nring commented 2 years ago
  1. Remove StickyNav - It's a cool feature but didn't really work well with our design
    1. The component is still in use, but I hobbled it to not really be "sticky". <StickyNav> can probably be deleted but its contents will need to be shifted to a different component.
    2. StickyNavContainer can be removed
    3. There are a bunch of props passed around in Layout related to StickyNav, those can be removed as well.
    4. Ensure that our position: fixed solution allows content to be visible on all pages