search

deptagency / dept-engineering-blog-ui

dept-engineering-blog-ui.vercel.app
MIT License
1 stars 3 forks source link

Refactor Header and SiteNav #41 and #42 #48

Closed cmdea closed 2 years ago

cmdea commented 2 years ago

Started refactoring the Header components and determined it would be prudent to address the SiteNav refactorings in the same PR.

I discussed with Briana and began using @emotion/styled to refactor and lay the basis for more maintainable styles going forward.

I implemented the basis of a spacings system in components/common/spacings.ts and then took some liberties with the paddings and margins used in the Header and SiteNav. There are slight visual differences (a pixel or two here and there), but the code is much improved imho.

issue #42 https://github.com/deptagency/dept-engineering-blog-ui/issues/41

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dept-engineering-blog-ui ✅ Ready (Inspect) Visit Preview May 9, 2022 at 6:57PM (UTC)
cmdea commented 2 years ago

Alright, I think I've resolved all the things