deptagency / dept-engineering-blog-ui

dept-engineering-blog-ui.vercel.app
MIT License
1 stars 3 forks source link

Refactor typography #49 #55

Closed cmdea closed 2 years ago

cmdea commented 2 years ago

This PR addresses issue #55. The main goal was to standardize/globalize the various stylings for headings, subheadings and copy text used throughout the project.

Since I changed a lot of files 😰, here's a quick overview of what I did:

(FYI: commit history is long because I squashed my previous PR on merge, will do the same here.)

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dept-engineering-blog-ui ✅ Ready (Inspect) Visit Preview May 12, 2022 at 8:19PM (UTC)
cmdea commented 2 years ago

This is looking great! I don't know if you ran lighthouse scores but check it out! master: image

refactor-typography image

(I think SEO went down because it's on a staging domain, but we can keep an eye on that)

Thank you for getting Storybook in too

I opened a fake PR over here and ran a lighthouse test to benchmark the scores of master code on a staging domain. Got the same result there as for this branch on staging. So, I don't think the SEO 83 is caused by the changes here! ✅