Closed cmdea closed 2 years ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
dept-engineering-blog-ui | ✅ Ready (Inspect) | Visit Preview | May 12, 2022 at 8:19PM (UTC) |
This is looking great! I don't know if you ran lighthouse scores but check it out!
master
:
refactor-typography
(I think SEO went down because it's on a staging domain, but we can keep an eye on that)
Thank you for getting Storybook in too
I opened a fake PR over here and ran a lighthouse test to benchmark the scores of master code on a staging domain. Got the same result there as for this branch on staging. So, I don't think the SEO 83 is caused by the changes here! ✅
This PR addresses issue #55. The main goal was to standardize/globalize the various stylings for headings, subheadings and copy text used throughout the project.
Since I changed a lot of files 😰, here's a quick overview of what I did:
/components
and ensured they would be used in storybookRenderContent
component:/components
(FYI: commit history is long because I squashed my previous PR on merge, will do the same here.)