deptagency / dept-engineering-blog-ui

dept-engineering-blog-ui.vercel.app
MIT License
1 stars 3 forks source link

fix: scroll-padding-top with respect to CareersPageNudge #88

Closed EthanStandel closed 1 year ago

vercel[bot] commented 1 year ago

@EthanStandel is attempting to deploy a commit to the Dept Engineering Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dept-engineering-blog-ui ❌ Failed (Inspect) Oct 3, 2022 at 10:57AM (UTC)
EthanStandel commented 1 year ago

@nring when I run yarn lint (which appears to be the only linting script), it works fine.

And unfortunately, I can't see anything else because I don't have access to the deptagency Vercel account.

nring commented 1 year ago

@EthanStandel I re-ran the build and got the same error:

Failed to compile.
--
11:16:17.728 |  
11:16:17.728 | ./components/SiteNav/components.tsx
11:16:17.728 | 11:1  Error: invalid import group member  ordered-imports/ordered-imports

Though I copied your changes locally and I think it's just complaining about no new line at the end of the file, which is weird given this error.

EthanStandel commented 1 year ago

@nring

Though I copied your changes locally and I think it's just complaining about no new line at the end of the file, which is weird given this error.

If you pull it locally, there is a newline at the end of the file, GH just doesn't show it. As for import order, if I try any other combination of import order for the new import (the Global component), VSC gives me a lint error suggesting that I did something wrong by changing it. Is it possible that the Vercel pipeline has a script that isn't actually available locally?

Notably, I can't even build locally because it says I'm missing environment variables (when I run with yarn dev it seems to give me a standard set of generic articles from Ghost itself so that was how I tested the changes locally).

> Build error occurred
Error: @tryghost/admin-api Config Invalid: 'key' undefined must have 26 hex characters
    at GhostAdminAPI (/Users/ethanstandel/workspace/dept-engineering-blog-ui/node_modules/@tryghost/admin-api/lib/admin-api.js:134:15)
    at new GhostAdminAPI (/Users/ethanstandel/workspace/dept-engineering-blog-ui/node_modules/@tryghost/admin-api/lib/admin-api.js:50:16)
    at /Users/ethanstandel/workspace/dept-engineering-blog-ui/.next/server/pages/p/[pid].js:29:18 {
  type: 'Error'
}
error Command failed with exit code 1.
nring commented 1 year ago

This will be fixed with #89 , but I want to keep this PR open to bug test to see if we can resolve this weird build failure.