Closed maxisawesome closed 6 years ago
I added the DFL logo to the readme! It's a little blurry, but nbd to me. SVG's are kinda odd on github, so I didn't use it, I used a smaller png instead.
Thanks!
Also, would you mind uploading a copy of the colab as an ipynb? Then we could change the link to reflect it. This would be helpful because then there's always a static version.
By bundle I mean I ran bundle exec jekyll serve
to display the page locally but I couldn't update jekyll correctly (IIRC).
I added a small "Max wrote this" and "End what Max wrote" to the ipython notebook, and other than that just a few added comments in the training loop. I just put the notebook in the main directory - wasn't sure of a more specific place that was better.
It's hard for me to comment on the ipynb directly, posting here instead:
- there are some bad parts importing in the LaTeX. It says "Unknown character" repeatedly.
I don't know... I don't see this. I added some LaTeX of the gradients. Let me know if you see that properly.
- while it's not a bad idea to include this review, it would probably be better if you rewrote and reworded it here instead of pasting the image.
I removed the image and wrote in the gradient updates with some brief explanation.
- I think we can get rid of this line as well because it's a rehash of what's in the copied image. --> "Note that we are "ascending" (ie maximizing) for the discriminator updates while we are "descending" (ie minimizing) for the generator updates, consistent with the definition of the "minimax" game defined above. The summation part of the updates is simply averaging over the batch."
Deleted the image, so I added a little bit of this back in.
- I think it would be better to get rid of the saturating loss as people don't use it in practice.
I added a comment that says "While the saturating loss appears in the original GAN paper, it is no longer used in practice. It is included for completeness." I can also just delete it if you'd like, the original request was to demonstrate the difference between the losses, which was why I put it in there at all.
Thanks for taking care of all of those! lgtm now.
(I still see the unknown
errors here, but when I loaded it into a jupyter display, they were gone. So it might be a Github issue.)
I removed the sentence saying "Let us know if you did this!" but you might wanna keep that. Lemme know if the notebook is good enough. I couldn't get the bundle to run locally, but I'm 95% sure the markdown I wrote will be fine. My b