depthfirstlearning / depthfirstlearning.com

Other
195 stars 29 forks source link

SVGD: Initial Review #35

Closed bhairavmehta95 closed 4 years ago

bhairavmehta95 commented 4 years ago

Some TODOs that are left:

The PDF links for all the notes will be in by tomorrow, but the Colab ones are there.

bhairavmehta95 commented 4 years ago

PDF notes are added.

cinjon commented 4 years ago

I'm a little confused. It seems like this is all Tex and PDFs. Is that right? More directly, will this run properly in jekyll?

bhairavmehta95 commented 4 years ago

image

For example, here's a screenshot of Week 3.

cinjon commented 4 years ago

You're right - i was wrong. The markdown was just hidden. Ok, so feedback in line.

cinjon commented 4 years ago

This is actually a fantastic first PR. Thanks much for making this easier. I mostly have grammar fixes to add up above, although I could suggest a bunch of changes to streamline it as well wrt language. I'm going to send it to the rest of the team for their feedback. When do you think you'll have the last week done because I suspect that there won't be much that we'll ask to change here.

avital commented 4 years ago

Thanks for resolving my concerns

cinjon commented 4 years ago

Looks mostly good. Left a few questions. Main concern is week 5 - is it done?

bhairavmehta95 commented 4 years ago

@cinjon Yes, W5 is done. This was the week I wasn't comfortable at all with posing other questions, because: 1. Background required was too far out of my comfort zone 2. Spanned too many topics

I can ask someone more knowledgeable than myself to provide some material, though.

R.e everything else, I will fix by tomorrow and push the changes.

cinjon commented 4 years ago

This lgtm! Want to squash the commits together into one coherent one? We can talk offline about publishing.

cinjon commented 4 years ago

🎉 lgtm!!! 💯